-
Notifications
You must be signed in to change notification settings - Fork 88
[Feature] Feature/jss 36 naga sdk add a make a request function to take #861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Ansonhkg
wants to merge
28
commits into
naga
from
feature/jss-36-naga-sdk-add-a-make-a-request-function-to-take
Closed
[Feature] Feature/jss 36 naga sdk add a make a request function to take #861
Ansonhkg
wants to merge
28
commits into
naga
from
feature/jss-36-naga-sdk-add-a-make-a-request-function-to-take
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-function-to-take Signed-off-by: Anson <[email protected]>
…-function-to-take
…o-take' of github.com:LIT-Protocol/js-sdk into feature/jss-36-naga-sdk-add-a-make-a-request-function-to-take
Base automatically changed from
feature/jss-37-optimisation-unify-shared-logic-with-an-option-to-override
to
naga
August 26, 2025 13:02
…-function-to-take
…auth signature and check expiration
…-function-to-take
…ure validation. This is similar to the existing `validateSessionSig` function.
…o-take' of github.com:LIT-Protocol/js-sdk into feature/jss-36-naga-sdk-add-a-make-a-request-function-to-take
…-function-to-take
…o-take' of github.com:LIT-Protocol/js-sdk into feature/jss-36-naga-sdk-add-a-make-a-request-function-to-take
…pt parameters directly
…-function-to-take
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
The use case is, generating a session keypair locally, and then getting a delegation signature on it. and then giving those items to a server, so that it can generate per-request session sigs as needed.
This PR is a prerequisite to support wrapped keys.
Logic
sessionKeyPairanddelegationAuthSigare provided -> Skip generation, use them directlyValidation